Adjustments for running hub in non-priv/non-systemd container #1718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For UBI container images this package/command is not installed by default so require it as the installation scriptlets need it. Ticket: ENT-12995
For example, an ubi9 container image contains systemctl command that will fail always because systemd is not started. Ticket: ENT-12653 Changelog: none
|
Thanks for submitting a PR! Maybe @craigcomstock can review this? |
|
@cf-bottom jenkins please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/12156/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-12156/ |
vpodzime
approved these changes
May 28, 2025
| @@ -14,6 +14,10 @@ Url: https://cfengine.com | |||
| BuildRoot: %{_topdir}/%{name}-%{version}-%{release}-buildroot | |||
| Obsoletes: cfengine3 < @@VERSION@@, cf-community < @@VERSION@@ | |||
| Requires: coreutils | |||
|
|
|||
| # installation scriptlets need hostname command, not present in UBI container images | |||
| Requires: hostname | |||
There was a problem hiding this comment.
I wonder if we should/could do /bin/hostname here instead, but it's probably just the same in the end.
larsewi
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.